search

scalecube / scalecube-services

Microservices library - scalecube-services is a high throughput, low latency reactive microservices library built to scale. It features: API-Gateways, service-discovery, service-load-balancing, the architecture supports plug-and-play service communication modules and features. built to provide performance and low-latency real-time stream-processing
http://scalecube.github.io/
Apache License 2.0
612 stars 106 forks source link

Change error qualifer format #751

Closed artem-v closed 4 years ago

artem-v commented 4 years ago

Migrate io.scalecube.services.error/:errorType to message with normal qualifier but with header denoting error type. Leave ErrorData as is.

Add _error_type header (name it by analog with _data_format).

Remove method Qualfier.isError, change inplementation of ServiceMessage.isError.

dudikrisher commented 4 years ago

@segabriel @artem-v Why field name is _error_type and not errorType ?

artem-v commented 4 years ago

@segabriel @artem-v Why field name is _error_type and not errorType ?

To be consistent with current naming conventions: 

  public static final String HEADER_DATA_TYPE = "_type";

  public static final String HEADER_DATA_FORMAT = "_data_format";
dudikrisher commented 4 years ago

But _type is never exposed to public and this one exposed so it should use convention of all the other fields in message

dudikrisher commented 4 years ago

lets fixed it here: https://github.com/scalecube/scalecube-services/issues/757