search

scalecube / scalecube-services

Microservices library - scalecube-services is a high throughput, low latency reactive microservices library built to scale. It features: API-Gateways, service-discovery, service-load-balancing, the architecture supports plug-and-play service communication modules and features. built to provide performance and low-latency real-time stream-processing
http://scalecube.github.io/
Apache License 2.0
612 stars 106 forks source link

Refactor ServiceMethodInvoker.authenticate line 158 #755

Closed artem-v closed 3 years ago

artem-v commented 4 years ago 
  private Mono<Object> authenticate(ServiceMessage message, Context context) {
    if (!methodInfo.isSecured()) {
      return Mono.just(Collections.emptyMap());
    }
    ...

Authnticator interface declares method Mono<A> authenticate(Map<String, String> credentials) => type A comes from client => it's wrong to return Collecrtions.emptyMap() on line 158.

artem-v commented 3 years ago

Done already. Closing.