search

scalecube / scalecube-travis-ci

this repository contains the scripts for making the
http://scalecube.io
2 stars 0 forks source link

support for Release candidates #33

Closed aharonha closed 5 years ago

skolomiiets commented 5 years ago

https://docs.travis-ci.com/user/deployment

tags: true: deployment is triggered if and only if $TRAVIS_TAG is set. Depending on your workflow, you may set $TRAVIS_TAG explicitly, even if this is a non-tag build when it was initiated. This causes the branch condition to be ignored.

As I see, with tags: true branch condition is ignored. Have you checked this, @aharonha ?

aharonha commented 5 years ago

https://docs.travis-ci.com/user/deployment

tags: true: deployment is triggered if and only if $TRAVIS_TAG is set. Depending on your workflow, you may set $TRAVIS_TAG explicitly, even if this is a non-tag build when it was initiated. This causes the branch condition to be ignored.

As I see, with tags: true branch condition is ignored. Have you checked this, @aharonha ?

tags: true will build the release.sh on both tags and master branch. I can not test it without creating some RC build and doing a simple (old) release

aharonha commented 5 years ago

DO not merge yet.