Only perform the :up action if the VM isn't in the :running state.

scalefactory / vagrant-cucumber

A Vagrant plugin to allow cucumber to work with VMs.

MIT License

40 stars 8 forks source link

Only perform the :up action if the VM isn't in the :running state. #15

Closed phyber closed 5 years ago

phyber commented 8 years ago

Since we require the user to perform a vagrant up before running the Cucumber tests, the action(:up) here seems to be optional. This change makes it so that the action is only performed if the VM isn't in the :running state.

This should save some time as the :up action would have rerun provisioners which shouldn't be needed as we either:

Have just performed a vagrant up.
Have just rolled back, so we're in the state snapshotted directly after performing a vagrant up.

randomvariable commented 8 years ago

Is this still a thing that needs merging?

jtopper commented 7 years ago

This needs a rebase, then it can merge.

phyber commented 5 years ago

Rebased against master and should be able to merge now.

madAndroid commented 5 years ago

Only 3 years in the making 😉

mbevc1 commented 5 years ago

Better late than never :grinning:

madAndroid commented 5 years ago

Indeed!! 😁

randomvariable commented 5 years ago

/lgtm