Setting data attribute "data-hide-360-logo" not only hides the logo, but also the arrow controls (cloudimage-360-left, cloudimage-360-right, etc.)

scaleflex / js-cloudimage-360-view

Engage your customers with a stunning 360 view of your products. Any questions or issues, please report to https://github.com/scaleflex/js-cloudimage-360-view/issues

Other

2.02k stars 232 forks source link

Setting data attribute "data-hide-360-logo" not only hides the logo, but also the arrow controls (cloudimage-360-left, cloudimage-360-right, etc.) #166

Open joshsedl opened 1 month ago

joshsedl commented 1 month ago

See https://codesandbox.io/p/sandbox/js-cloudimage-360-view-example-forked-l5czys?workspaceId=8f1a8c32-1ff9-48b7-95f5-36bf3e63b3e4.

Removing "data-hide-360-logo" will display the arrow controls once again.

JPustkuchen commented 1 month ago

Looks like this return statement causes this bug? https://github.com/scaleflex/js-cloudimage-360-view/blob/39469ed58823ebe45388a5a885d880e288c99366/src/ci360.service.js#L922

To me it looks like the return should simply be removed?

JPustkuchen commented 1 month ago

Maintainers please check if that fix is correct. Thanks!