search

scaleflex / js-cloudimage-360-view

Engage your customers with a stunning 360 view of your products. Any questions or issues, please report to https://github.com/scaleflex/js-cloudimage-360-view/issues
Other
2.02k stars 232 forks source link

Lazysizes lazyloading demo is missing the data-lazyload attribute, so the demo doesn't work #168

Open thomasfrobieter opened 1 month ago

thomasfrobieter commented 1 month ago

https://codesandbox.io/p/sandbox/js-cloudimage-360-view-examples-ux850x?file=%2Findex.html%3A41%2C34

data-lazyload="true"

EDIT:

Turns out, data-lazyload doesn't change anything, all images are still loaded without clicking the "360°"-button:

https://codesandbox.io/p/sandbox/js-cloudimage-360-view-examples-forked-kr9ctf

So I think 'data-lazyload-selector' is also required. Not sure how to use this..

JPustkuchen commented 1 month ago

I can confirm this, checking the network tab in the browser console. Images are not lazy loaded. They even load outside the viewport in the demo.