if ci-src is left empty, error will occur and results in blocking failure

scaleflex / js-cloudimage-responsive

Cloudimage Responsive will smartly resize, compress and accelerate images across the World in your site for all devices. The plugin supports lazy loading technique with fancy animation on image load. Any questions or issues, please report to https://github.com/scaleflex/js-cloudimage-responsive/issues

Other

68 stars 15 forks source link

if ci-src is left empty, error will occur and results in blocking failure #2

Closed randallmlough closed 5 years ago

randallmlough commented 5 years ago

I noticed that if ci-src is passed an empty string value, it will fail and block all proceeding functions. In a perfect world we would always pass in a value for ci-src, but things happen. It would be helpful for the library to check for an empty string and either do nothing or return the users default 404 image.

dzmitry-stramavus commented 5 years ago

@randallmlough , hey

thanks for opening the issue! Yes, totally agree. It will be implemented in next release

dzmitry-stramavus commented 5 years ago

@randallmlough , hey

done in v2.2.0