search

scalesim-project / krittika

Heterogenous ML accelerator
MIT License
16 stars 11 forks source link

Discrepancy in Krittika vs Scalesim when using estimate mode. #14

Open mmanchali3 opened 6 months ago

mmanchali3 commented 6 months ago

Setting the bandwidth mode to CALC, results in scale-sim and krittika diverging in the following ways. 1) In Standalone scalesim-v2, image in single layer sim run method, if we use bw mode to CALC you end up setting estimate_bandwidth_mode to True, which ends up calling the service reads from read buffer estimate class. 2) In Krittika, image You end up setting estimate_bandwidth_mode to False, resulting in calling service reads from read buffer class.

These two have very different behaviors and one of them is wrong.

ritikraj7 commented 6 months ago

Hi @mmanchali3, great catch, that's an error in krittika. I will update the code. For the purpose of 8803 project, I would suggest using only USER mode.