Closed ctrlok closed 7 years ago
Thanks for merging.
BTW, maybe it will be better to use mcnutils.MultiError
like in original plugins? Example
@QuentinPerez actually, I have some problems with this changes.
_, err = cl.GetServer(d.ServerID)
will return no error if d.ServerID
is an empty string.
```
(bench-3) (*api.ScalewayServer)(0xc4200e9340)({
(bench-3) Arch: (string) "",
(bench-3) Identifier: (string) "",
(bench-3) Name: (string) "",
(bench-3) CreationDate: (string) "",
(bench-3) ModificationDate: (string) "",
(bench-3) Image: (api.ScalewayImage) {
(bench-3) Identifier: (string) "",
(bench-3) Name: (string) "",
(bench-3) CreationDate: (string) "",
(bench-3) ModificationDate: (string) "",
(bench-3) RootVolume: (api.ScalewayVolume) {
(bench-3) Identifier: (string) "",
(bench-3) Size: (interface {})
I think it is becouse s.GetResponsePaginate
will return no error, but list of servers. I will made PR to cli about this.
@QuentinPerez thanks! please, update vendored cli package to fix the issue.
@ctrlok done :)
Hi, while I try to fix #63 I found some bug: if docker-machine fail create instance it still create ip address. And that address not deleted with
docker-machine rm
.