scaleway / image-tools

:nut_and_bolt: Scripts used to create Images on Scaleway - https://github.com/scaleway-community
https://github.com/scaleway-community
MIT License
117 stars 36 forks source link

Cleanse shell scripts of bashisms #172

Closed muhmuhten closed 8 years ago

muhmuhten commented 8 years ago

went through skeleton-common/usr/local/*bin and eliminated nonportable shell constructs in files marked with a bash shebang so that they should run correctly under a posix shell.

The results are checked with checkbashisms and tested under alpine's busybox ash.

I may have gone a bit overboard in the case of scw-check-kernel which is close to rewritten. Feel free to cherry-pick that out.

moul commented 8 years ago

Awesome, we need to check this scripts before merging, but it globally looks good