search

scaleway / netbox-netprod-importer

Poll data from network devices in production and import it into netbox
GNU General Public License v3.0
101 stars 31 forks source link

Vlan +802.1Q Mode #22

Closed VictorPavlushin closed 5 years ago

VictorPavlushin commented 5 years ago

1) Add support 802.1Q Mode 2) Added binding to vlan. Vlans are not imported

aruhier commented 5 years ago

Thanks a lot, I'll merge it in another branch, change a few things, and merge the result in master ;)

VictorPavlushin commented 5 years ago

Overall good, thanks a lot! I just requested some changes and we are good to go.

I would not want to customize, but 3 months have passed, I want to give the link to the engineers to use. 👍

aruhier commented 5 years ago

I made some changes and fixes to your PR. Thanks a lot for your work, even if you should really try to keep a certain level of care in your commits in the future (typo in variables and functions, commits that you could rebase to avoid some unused code, etc.).

Sorry for the delay, as I've said in the readme, I don't maintain this project anymore. But please fork it if you want to continue to work on this.

aruhier commented 5 years ago

I included your changes into a new release ;)