search

scaleway / netbox-netprod-importer

Poll data from network devices in production and import it into netbox
GNU General Public License v3.0
104 stars 32 forks source link

Update interconnections for netbox 2.5 #9

Closed VictorPavlushin closed 5 years ago

VictorPavlushin commented 5 years ago

Patch to upgrade to Netbox 2.5

aruhier commented 5 years ago

Hi, Thanks a lot for the request, LGTM!

However, I will probably open an issue for later, to use in a more clever way the cables than what we could do before with interconnections. I had the issue at Online.net before, when you have a patch panel for example, netbox-netprod-importer will just break the previous connection and replace it with a direct cable between the 2 LLDP neighbors (as we work at the L2 level). Maybe we can check the final extremity of the entire cable to avoid that. It could be something to work on.

aruhier commented 5 years ago

Sorry, I saw a typo that I missed in my review, I will fix it in another commit ;)

aruhier commented 5 years ago

Also, I will add a cron in travis to weekly run the tests. I hope it will avoid the dependency issue you had.