search

scaleway / scaleway-csi

Container Storage Interface (CSI) Driver for https://www.scaleway.com/block-storage/
Apache License 2.0
57 stars 17 forks source link

[WIP] Allow fsType as parameter of CreateVolume requests #34

Closed Tristan971 closed 3 years ago

Tristan971 commented 3 years ago

What value does this feature bring to end users ?

This is mainly intended to be able to provision XFS-formatted PVCs

How urgent is the need (nice to have feature or need to have) ?

nice to have

Does this align with the goals of scaleway-csi ?

I think so?

From looking at https://github.com/scaleway/scaleway-csi/blob/2092531de88b8b381724b6202769b4bb33a029d9/driver/diskutils.go#L202 it looks like it will look for a mkfs.<fsType> binary and use it

Also from https://github.com/scaleway/scaleway-csi/blob/2092531de88b8b381724b6202769b4bb33a029d9/driver/diskutils.go#L429-L435 we see that resize is technically also already there

and finally https://github.com/scaleway/scaleway-csi/blob/master/Dockerfile#L21-L22 has xfsprogs bundled, so the binary is there already

Marked as WIP because I'm not sure where/how to add tests for this change, nor if that's enough to make this work. Let me know

Thanks

Sh4d1 commented 3 years ago

Hey 👋 It's already possible through https://github.com/scaleway/scaleway-csi/blob/2092531de88b8b381724b6202769b4bb33a029d9/examples/kubernetes/README.md#choose-the-filesystem-type 😄 closing :)

Tristan971 commented 3 years ago

Hey 👋 It's already possible through https://github.com/scaleway/scaleway-csi/blob/2092531de88b8b381724b6202769b4bb33a029d9/examples/kubernetes/README.md#choose-the-filesystem-type 😄 closing :)

good lord I can't read 🤦 sorry...