search

scaleway / serverless-scaleway-functions

Plugin for Serverless Framework to allow users to deploy their serverless applications on Scaleway Functions
MIT License
78 stars 25 forks source link

Serverless container based on private image can not be deployed #98

Closed korridor closed 2 years ago

korridor commented 2 years ago

I want to deploy a serverless container that uses a Dockerfile that is based on a image in the Scaleway Docker registry.

The image that I want to deploy looks something like this:

FROM rg.nl-ams.scw.cloud/some/registry:tag

RUN something

COPY . .

This fails because the build command is not authenticated in the code, only the push command.

Code for build: https://github.com/scaleway/serverless-scaleway-functions/blob/master/deploy/lib/pushContainers.js#L40 Code for push: https://github.com/scaleway/serverless-scaleway-functions/blob/master/deploy/lib/pushContainers.js#L43

norbjd commented 2 years ago

Hello :wave:

Thanks for reporting the issue. The linked PR should solve this. After the reviews are done, we'll release a new version with the fix!

korridor commented 2 years ago

Thanks, the pull request should work for my use case! 👍

norbjd commented 2 years ago

Hello @korridor, a new version (0.4.2) have been released and fixes this issue. Tell us if you are still facing this issue and we'll reopen it.