scality / Arsenal

Common utilities for the open-source Scality S3 project components
Apache License 2.0
15 stars 19 forks source link

ARSN-376 Probe response logic should be handled in the handler #2189

Closed nicolas2bert closed 11 months ago

nicolas2bert commented 11 months ago

NOTE: code has already been reviewed.

Currently, the probe response logic is distributed between Backbeat probe handlers and Arsenal's onRequest method.

This scattered approach causes confusion for developers and results in bugs.

The solution is to centralize the probe response logic exclusively within the Backbeat probe handlers.

bert-e commented 11 months ago

Hello nicolas2bert,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 11 months ago

Incorrect fix version

The Fix Version/s in issue ARSN-376 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of ARSN-376, or the target branch of this pull request.

nicolas2bert commented 11 months ago

ping

bert-e commented 11 months ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

nicolas2bert commented 11 months ago

@bert-e approve

bert-e commented 11 months ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 11 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue ARSN-376.

Goodbye nicolas2bert.