Closed jonathan-gramain closed 11 months ago
My role is to assist you with the merge of this
pull request. Please type @bert-e help
to get information
on this process, or consult the user documentation.
Status report is not available.
The Fix Version/s
in issue ARSN-380 contains:
7.70.16
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
7.70.16
8.1.117
Please check the Fix Version/s
of ARSN-380, or the target
branch of this pull request.
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve
and /create_pull_requests
commands will automatically
create the integration branches.
/create_integration_branches
I have created the integration data for the additional destination branches.
improvement/ARSN-380-delimiterVersionsInheritFromExtension
into
development/7.70
development/8.1
The following branches will NOT be impacted:
development/6.4
development/7.10
development/7.4
You can set option create_pull_requests
if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
The following approvals are needed before I can proceed with the merge:
the author
2 peers
The following options are set: create_integration_branches
/approve
The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.
The changeset will be merged in:
:heavy_check_mark: development/7.70
:heavy_check_mark: development/8.1
The following branches will NOT be impacted:
development/6.4
development/7.10
development/7.4
There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a member of the admin team now.
The following options are set: approve, create_integration_branches
I have successfully merged the changeset of this pull request into targetted development branches:
:heavy_check_mark: development/7.70
:heavy_check_mark: development/8.1
The following branches have NOT changed:
development/6.4
development/7.10
development/7.4
Please check the status of the associated issue ARSN-380.
Goodbye jonathan-gramain.
Small refactor of DelimiterVersions class to inherit from the base class Extension rather than Delimiter. Copy the missing fields and methods from
Delimiter
.This prepares for merging ARSN-379 which would otherwise cause a lot of incompatibilities due to changes in the interface of
DelimiterVersions
from S3C-8242.Other minor tweaks:
reset
nextVersionIdMarker
when skipping a common prefixrename
this.Contents
tothis.Versions
as we don't need to keep compatibility withDelimiter
, and as it is the name used in the final result