bert-e
commented
6 months ago Hello jonathan-gramain,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Available options
name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |Available commands
name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |Status report is not available.
jonathan-gramain
Note for reviews: easier to review individual commits.
bump werelogs dependency
use local RequestLogger in DataWrapper.batchDelete
Create a local RequestLogger in batchDelete(): this allows to track the elapsed time of the batch delete sub-request, and avoids being forced to create a new request logger before calling the function (due to the call to
log.end()), which was error-prone and hardly maintainable.sanitize use of log object in DataWrapper.delete()
Don't assume that we can safely call
end()on the passed log object if there is no callback (separation of concerns). additionally, an error object was passed whereend()expects a string as a message, causing implicit conversion.Since errors are already logged, there is no need to bind the
callbackobject tolog.end(there is no strong reason to log the elapsed time there, the only use I can see where we don't pass a callback in Cloudserver is to support deletion of old metadata with a string as location array. IMHO not worth the complexity of adding it there, as the rest of the API doesn't log elapsed time anyways except forbatchDelete).