search

scality / Arsenal

Common utilities for the open-source Scality S3 project components
Apache License 2.0
15 stars 19 forks source link

ARSN-430 Add new KMS backend with account-level default encryption key management #2258

Closed nicolas2bert closed 1 month ago

nicolas2bert commented 2 months ago

Context:

Changes in this PR:

bert-e commented 2 months ago

Hello nicolas2bert,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 2 months ago

Incorrect fix version

The Fix Version/s in issue ARSN-430 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of ARSN-430, or the target branch of this pull request.

nicolas2bert commented 2 months ago

ping

bert-e commented 2 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

nicolas2bert commented 2 months ago

/create_integration_branches

bert-e commented 2 months ago

Conflict

A conflict has been raised during the creation of integration branch w/8.1/improvement/ARSN-430/KMS-client with contents from improvement/ARSN-430/KMS-client and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/improvement/ARSN-430/KMS-client origin/development/8.1
 $ git merge origin/improvement/ARSN-430/KMS-client
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/improvement/ARSN-430/KMS-client

The following options are set: create_integration_branches

bert-e commented 2 months ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

The following options are set: create_integration_branches

bert-e commented 2 months ago

History mismatch

Merge commit #c6b38fe849a4858bea9a9e056a3061e2a7e42136 on the integration branch w/8.1/improvement/ARSN-430/KMS-client is merging a branch which is neither the current branch improvement/ARSN-430/KMS-client nor the development branch development/8.1.

It is likely due to a rebase of the branch improvement/ARSN-430/KMS-client and the merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

nicolas2bert commented 1 month ago

@bert-e reset

bert-e commented 1 month ago

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

bert-e commented 1 month ago

Conflict

A conflict has been raised during the creation of integration branch w/8.1/improvement/ARSN-430/KMS-client with contents from improvement/ARSN-430/KMS-client and development/8.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.1/improvement/ARSN-430/KMS-client origin/development/8.1
 $ git merge origin/improvement/ARSN-430/KMS-client
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.1/improvement/ARSN-430/KMS-client

The following options are set: create_integration_branches

bert-e commented 1 month ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

The following options are set: create_integration_branches

nicolas2bert commented 1 month ago

@bert-e approve

bert-e commented 1 month ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue ARSN-430.

Goodbye nicolas2bert.

The following options are set: approve, create_integration_branches