Memory leak during internal object listing

[williamlardier]

• Happens when the Skip algorithms tells the function to skip an entry.
• In this case, we recursively call the internalListObject function.
• However, we never properly close the stream created from the Transform object, that requires specific cleanup.
• Overall, the logic is too complex, so cleaning is now centralized and modular, so we clean anything that is still there, in a more clear fashion: we clean any of the three streams. If the stream was already destroyed, the operation is a no-op, but at least, all paths now lead to a consistent cleaning of the resources.

Issue: ARSN-437

For reference, some tests were started to automate memory leak detection, but not very stable so far, or require to run it for long times: https://github.com/scality/Arsenal/compare/bugfix/ARSN-437-ballooning?expand=1

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options

name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |

Available commands

name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-437 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.1.139

Please check the Fix Version/s of ARSN-437, or the target branch of this pull request.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.90%. Comparing base (c993537) to head (94c7038). Report is 5 commits behind head on development/8.1.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## development/8.1 #2264 +/- ## =================================================== + Coverage 64.84% 64.90% +0.06% =================================================== Files 215 215 Lines 17287 17298 +11 Branches 3535 3514 -21 =================================================== + Hits 11209 11228 +19 + Misses 6063 6055 -8 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

[williamlardier]

/create_integration_branches

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/ARSN-437 into development/8.1
• w/8.2/bugfix/ARSN-437 will be merged into development/8.2

The following branches will NOT be impacted:

• development/6.4
• development/7.10
• development/7.4
• development/7.70

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following options are set: create_integration_branches

[williamlardier]

/approve

[bert-e]

I have successfully merged the changeset of this pull request into targetted development branches:

• :heavy_check_mark: development/8.1

• :heavy_check_mark: development/8.2

The following branches have NOT changed:

• development/6.4
• development/7.10
• development/7.4
• development/7.70

Please check the status of the associated issue ARSN-437.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches