search

scality / Arsenal

Common utilities for the open-source Scality S3 project components
Apache License 2.0
14 stars 19 forks source link

Create some common configuration management lib #52

Open ghost opened 8 years ago

ghost commented 8 years ago

Currently, for common parts of the configuration in our different projects, we're rewriting those in each project.

The result is that some common configuration bits appear completely differently in the way the configuration of each project is structured. This was actually confusing for some people trying to look at the different configuration files.

Such common configuration should have the same format, and thus be written only once. As such; I'm suggesting that we write a small config management lib, that at least includes the logging concern, and that generates a werelogs configuration object from the given configuration section. It would help harmonize configuration formats, and could easily bring more flexibility to our logging configuration.

adrienverge commented 8 years ago

Agreed.

I proposed this (a common config lib) last year, but it was rejected because 1) it would add another dep 2) we wanted configuration to be "hidden" to customers, i.e. not accessible through a file. Please make sure those are not considered problems now.

ghost commented 8 years ago

1) we've already come back on that dependency decision since we're now going to use arsenal for common error management. 2) even if we do not want to explicitly show the configurations, some will get to it, and it's better to be consistent throughout the project in any case, and reduce the ducplication of the code for the configuration management

As such, I do not think it is a problem anymore :)