search

scality / Droplet

Cloud storage client library
http://www.scality.com
Other
54 stars 33 forks source link

Check for NULL hresult from dpl_gethostbyname2_r() #220

Closed jjd-git closed 8 years ago

jjd-git commented 8 years ago

If dpl_gethostbyname2_r() returns a NULL hresult, the host wasn't found, and we should just return instead of trying to use it.

ghost commented 8 years ago

The actual function (gethostbyname2_r) behind it is even actually deprecated, according to the manpages. Maybe we should consider updating it altogether, though I do not have any of the supported OSes at hand to test a potential upgrade ?

jjd-git commented 8 years ago

I don't know that any of those functions are likely to go away any time soon. Considering how difficult it would be to test any change, I don't think it's worth the risk.

From: David Pineau [mailto:notifications@github.com] Sent: Tuesday, March 29, 2016 12:01 PM To: scality/Droplet Cc: James Demski Subject: Re: [scality/Droplet] Check for NULL hresult from dpl_gethostbyname2_r() (#220)

The actual function (gethostbyname2_r) behind it is even actually deprecated, according to the manpages. Maybe we should consider updating it altogether, though I do not have any of the supported OSes at hand to test a potential upgrade ?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHubhttps://github.com/scality/Droplet/pull/220#issuecomment-202974311