search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

BB-451: Add fallback timestamp to delete notifications #2453

Closed rachedbenmustapha closed 1 year ago

rachedbenmustapha commented 1 year ago

Delete notification events were missing the eventTime attribute because the last-modified MD field was not present in the raft log. This change uses the raft log entries' timestamp attribute in its place for delete operations.

bert-e commented 1 year ago

Hello rachedbenmustapha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 1 year ago

Incorrect fix version

The Fix Version/s in issue BB-451 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-451, or the target branch of this pull request.

rachedbenmustapha commented 1 year ago

/approve

bert-e commented 1 year ago

Conflict

A conflict has been raised during the creation of integration branch w/8.5/feature/BB-451-delete-notification-fields with contents from feature/BB-451-delete-notification-fields and development/8.5.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.5/feature/BB-451-delete-notification-fields origin/development/8.5
 $ git merge origin/feature/BB-451-delete-notification-fields
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.5/feature/BB-451-delete-notification-fields

The following options are set: approve

bert-e commented 1 year ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 1 year ago

Build failed

The build for commit did not succeed in branch w/8.7/feature/BB-451-delete-notification-fields.

The following options are set: approve

bert-e commented 1 year ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 1 year ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-451.

Goodbye rachedbenmustapha.