search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

Call get metadata after error to discover new topic created by another consumer or producer #2455

Closed KillianG closed 1 year ago

KillianG commented 1 year ago

Issue: BB-453

bert-e commented 1 year ago

Hello killiang,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 1 year ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

francoisferrand commented 1 year ago

this should go on 8.6, this is bugfix

bert-e commented 1 year ago

Incorrect fix version

The Fix Version/s in issue BB-453 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-453, or the target branch of this pull request.

bert-e commented 1 year ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

KillianG commented 1 year ago

LGTM, but couldn't it be better as a solution to this issue to pre-create the archive topic with the wanted number of partitions, e.g. at deployment time, or when the process that produces to this topic starts?

I don't think so, because in the case the customer wants to add more partitions to a topic, we don't want the default 10mn lag..

KillianG commented 1 year ago

/approve

bert-e commented 1 year ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 1 year ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

francoisferrand commented 1 year ago

couldn't it be better as a solution to this issue to pre-create the archive topic with the wanted number of partitions, e.g. at deployment time, or when the process that produces to this topic starts?

yes, this is (kind of) planned. We already started managing topics from ZKOP, and will finish the effort in next quarter(s): e.g. covering the few topics (esp. cold) which are not yet managed there, then disabling the creating of the topics by consumers & producers.

bert-e commented 1 year ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-453.

Goodbye killiang.