search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

Fix missing originOp on lifecycle metadata updates #2477

Closed francoisferrand closed 10 months ago

francoisferrand commented 11 months ago

Incorrect or missing originOp causes incorrectly duplicated bucket notifications, missing notifications or wrong notifications being sent.

Issue: BB-472

codecov[bot] commented 11 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0d70c99) 63.10% compared to head (2854e21) 62.92%.

:exclamation: Current head 2854e21 differs from pull request most recent head 4ff27cc. Consider uploading reports for the commit 4ff27cc to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2477/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [extensions/gc/tasks/GarbageCollectorTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9nYy90YXNrcy9HYXJiYWdlQ29sbGVjdG9yVGFzay5qcw==) | `82.24% <ø> (ø)` | | | [.../lifecycle/tasks/LifecycleColdStatusArchiveTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdGFza3MvTGlmZWN5Y2xlQ29sZFN0YXR1c0FyY2hpdmVUYXNrLmpz) | `89.79% <100.00%> (+0.21%)` | :arrow_up: | | [...le/tasks/LifecycleResetTransitionInProgressTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdGFza3MvTGlmZWN5Y2xlUmVzZXRUcmFuc2l0aW9uSW5Qcm9ncmVzc1Rhc2suanM=) | `80.00% <100.00%> (+1.05%)` | :arrow_up: | | [...sions/replication/tasks/UpdateReplicationStatus.js](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi90YXNrcy9VcGRhdGVSZXBsaWNhdGlvblN0YXR1cy5qcw==) | `80.53% <100.00%> (+0.08%)` | :arrow_up: | | [extensions/lifecycle/tasks/LifecycleTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdGFza3MvTGlmZWN5Y2xlVGFzay5qcw==) | `84.44% <0.00%> (-3.90%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2477/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `65.61% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `62.16% <ø> (ø)` | | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `68.97% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `71.10% <25.00%> (-0.84%)` | :arrow_down: | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `73.87% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.27% <100.00%> (-0.06%)` | :arrow_down: | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2477/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## improvement/BB-447 #2477 +/- ## ====================================================== - Coverage 63.10% 62.92% -0.19% ====================================================== Files 191 191 Lines 12609 12616 +7 ====================================================== - Hits 7957 7938 -19 - Misses 4642 4668 +26 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2477/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2477/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `40.94% <33.33%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 10 months ago

Hello francoisferrand,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 10 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

francoisferrand commented 10 months ago

/approve

bert-e commented 10 months ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 10 months ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 10 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-472.

Goodbye francoisferrand.