scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

Restart connectors on task failure #2489

Closed Kerkesni closed 8 months ago

Kerkesni commented 9 months ago

Restart Kafka-Connect connectors when they are in a failed state or if their tasks are in a failed state.

Issue: BB-480

bert-e commented 9 months ago

Hello kerkesni,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0e1bd9) 63.13% compared to head (fb8eeac) 63.20%. Report is 23 commits behind head on development/8.6.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2489/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [extensions/oplogPopulator/modules/Allocator.js](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9vcGxvZ1BvcHVsYXRvci9tb2R1bGVzL0FsbG9jYXRvci5qcw==) | `87.50% <ø> (ø)` | | | [extensions/oplogPopulator/modules/Connector.js](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9vcGxvZ1BvcHVsYXRvci9tb2R1bGVzL0Nvbm5lY3Rvci5qcw==) | `84.44% <100.00%> (+1.31%)` | :arrow_up: | | [...nsions/oplogPopulator/modules/ConnectorsManager.js](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9vcGxvZ1BvcHVsYXRvci9tb2R1bGVzL0Nvbm5lY3RvcnNNYW5hZ2VyLmpz) | `91.37% <100.00%> (+4.84%)` | :arrow_up: | | [lib/wrappers/KafkaConnectWrapper.js](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3dyYXBwZXJzL0thZmthQ29ubmVjdFdyYXBwZXIuanM=) | `100.00% <100.00%> (ø)` | | | [extensions/oplogPopulator/OplogPopulatorMetrics.js](https://app.codecov.io/gh/scality/backbeat/pull/2489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9vcGxvZ1BvcHVsYXRvci9PcGxvZ1BvcHVsYXRvck1ldHJpY3MuanM=) | `63.63% <75.00%> (+1.13%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2489/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `65.61% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `62.21% <100.00%> (+0.03%)` | :arrow_up: | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `68.61% <ø> (-0.36%)` | :arrow_down: | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `71.99% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.90% <96.77%> (+2.02%)` | :arrow_up: | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.34% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2489/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.6 #2489 +/- ## =================================================== + Coverage 63.13% 63.20% +0.07% =================================================== Files 191 191 Lines 12619 12647 +28 =================================================== + Hits 7967 7994 +27 - Misses 4642 4643 +1 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.67% <0.00%> (-0.07%)` | :arrow_down: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.51% <0.00%> (-0.03%)` | :arrow_down: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.26% <0.00%> (+0.07%)` | :arrow_up: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.90% <0.00%> (-0.01%)` | :arrow_down: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.61% <0.00%> (-0.05%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2489/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `41.11% <97.22%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 9 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

bert-e commented 9 months ago

Incorrect fix version

The Fix Version/s in issue BB-480 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-480, or the target branch of this pull request.

Kerkesni commented 8 months ago

/approve

bert-e commented 8 months ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 8 months ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 8 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-480.

Goodbye kerkesni.