search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

include accountId in cold delete kafka messages #2501

Closed Kerkesni closed 8 months ago

Kerkesni commented 8 months ago

Cold delete Kafka messages need to contain the accountId like for every other cold operation.

Issue: BB-508

bert-e commented 8 months ago

Hello kerkesni,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Status report is not available.

bert-e commented 8 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 63.74%. Comparing base (d57524f) to head (1e4a5c0).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2501/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files](https://app.codecov.io/gh/scality/backbeat/pull/2501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [lib/models/ColdStorageStatusQueueEntry.js](https://app.codecov.io/gh/scality/backbeat/pull/2501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL21vZGVscy9Db2xkU3RvcmFnZVN0YXR1c1F1ZXVlRW50cnkuanM=) | `93.75% <ø> (ø)` | | | [extensions/lifecycle/LifecycleQueuePopulator.js](https://app.codecov.io/gh/scality/backbeat/pull/2501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvTGlmZWN5Y2xlUXVldWVQb3B1bGF0b3IuanM=) | `57.00% <84.21%> (+1.33%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2501/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `65.90% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `62.46% <ø> (-0.02%)` | :arrow_down: | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `73.15% <84.21%> (+0.07%)` | :arrow_up: | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.90% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.47% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2501/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.6 #2501 +/- ## =================================================== + Coverage 63.73% 63.74% +0.01% =================================================== Files 192 192 Lines 12817 12821 +4 =================================================== + Hits 8169 8173 +4 Misses 4638 4638 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.54% <0.00%> (-0.01%)` | :arrow_down: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.57% <0.00%> (-0.02%)` | :arrow_down: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.39% <0.00%> (-0.01%)` | :arrow_down: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.89% <0.00%> (-0.01%)` | :arrow_down: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.47% <0.00%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `41.79% <84.21%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
Kerkesni commented 8 months ago

/approve

bert-e commented 8 months ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 8 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-508.

Goodbye kerkesni.

The following options are set: approve