Closed Kerkesni closed 7 months ago
My role is to assist you with the merge of this
pull request. Please type @bert-e help
to get information
on this process, or consult the user documentation.
Status report is not available.
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve
and /create_pull_requests
commands will automatically
create the integration branches.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.70%. Comparing base (
1e4a5c0
) to head (accbde0
).
I have created the integration data for the additional destination branches.
bugfix/BB-507
into
development/8.6
development/8.7
The following branches will NOT be impacted:
development/7.10
development/7.4
development/7.70
development/8.5
You can set option create_pull_requests
if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: approve
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve
and /create_pull_requests
commands will automatically
create the integration branches.
/approve
Merge commit #7bf30e15e1c854a162e1feeb593d4fce0841588c on the integration branch
w/8.7/bugfix/BB-507
is merging a branch which is neither the current
branch bugfix/BB-507
nor the development branch
development/8.7
.
It is likely due to a rebase of the branch bugfix/BB-507
and the
merge is not possible until all related w/*
branches are deleted or updated.
Please use the reset
command to have me reinitialize these branches.
The following options are set: approve
/reset
I have successfully deleted this pull request's integration branches.
The following options are set: approve
I have created the integration data for the additional destination branches.
bugfix/BB-507
into
development/8.6
development/8.7
The following branches will NOT be impacted:
development/7.10
development/7.4
development/7.70
development/8.5
You can set option create_pull_requests
if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: approve
I have successfully merged the changeset of this pull request into targetted development branches:
:heavy_check_mark: development/8.6
:heavy_check_mark: development/8.7
The following branches have NOT changed:
development/7.10
development/7.4
development/7.70
development/8.5
Please check the status of the associated issue BB-507.
Goodbye kerkesni.
The following options are set: approve
Instead of duplicating the notification logic we set the correct originOp when updating the metadata to trigger the replication failure notification. (Bucket notification listens to the oplog and sends notification based on the originOp field in the metadata)
At the end of a failed replication we update the metadata with the failure status that ends up in the oplog topic. So this does not add any overhead in terms of extra Kafka messages being pushed to any of the topics.
This also fixes the duplicate notifications bug where we send as many notifications as destinations we have in case they use the same internal topic (bug already fixed in notification code).
Issue: BB-507