search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

add missing overhead field used in S3C #2546

Closed Kerkesni closed 3 weeks ago

Kerkesni commented 4 weeks ago

Metadata adds versionId as an extra field in the oplog's delete events as they originally contain no metadata. These are needed for Bucket notification.

Note: Updating Bucket Notifications to use this field will be addressed in another ticket.

Issue: BB-535

bert-e commented 4 weeks ago

Hello kerkesni,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 4 weeks ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.33%. Comparing base (a1e9895) to head (04fa6b4). Report is 7 commits behind head on development/8.6.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2546/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2546?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [lib/queuePopulator/LogReader.js](https://app.codecov.io/gh/scality/backbeat/pull/2546?src=pr&el=tree&filepath=lib%2FqueuePopulator%2FLogReader.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3F1ZXVlUG9wdWxhdG9yL0xvZ1JlYWRlci5qcw==) | `38.78% <ø> (ø)` | | | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `74.00% <ø> (ø)` | | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `68.70% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `74.86% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.42% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2546/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.76% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.6 #2546 +/- ## ================================================ Coverage 69.33% 69.33% ================================================ Files 194 194 Lines 12791 12791 ================================================ Hits 8869 8869 Misses 3912 3912 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.66% <ø> (ø)` | | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.56% <ø> (ø)` | | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.76% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.47% <ø> (ø)` | | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.55% <ø> (ø)` | | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.39% <ø> (ø)` | | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.88% <ø> (ø)` | | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `18.97% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `42.94% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
francoisferrand commented 3 weeks ago

I wonder if we should not push the change bit further, to abstract the difference : eg store the versionId (and possibly other fields) in the same place whatever the backend, so that we limit the difference to existing adapters (like LogReader implementations) and have a single code path to deal with in extensions.

Not sure it fits in this ticket though, and/or not be fully possible as we need to handle "existing" objects already in kafka as well

Kerkesni commented 3 weeks ago

/approve

bert-e commented 3 weeks ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e commented 3 weeks ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 3 weeks ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-535.

Goodbye kerkesni.