search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
53 stars 19 forks source link

Improvement/bb 514 handle lifecycle rules #2548

Open benzekrimaha opened 3 weeks ago

benzekrimaha commented 3 weeks ago

Issue : BB-514

bert-e commented 3 weeks ago

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 3 weeks ago

Incorrect fix version

The Fix Version/s in issue BB-514 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-514, or the target branch of this pull request.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.24%. Comparing base (53ffd8e) to head (efd9721). Report is 3 commits behind head on development/8.7.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2548/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2548?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [extensions/lifecycle/LifecycleConfigValidator.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=extensions%2Flifecycle%2FLifecycleConfigValidator.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvTGlmZWN5Y2xlQ29uZmlnVmFsaWRhdG9yLmpz) | `85.71% <100.00%> (+2.38%)` | :arrow_up: | | [...ecycle/bucketProcessor/LifecycleBucketProcessor.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=extensions%2Flifecycle%2FbucketProcessor%2FLifecycleBucketProcessor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvYnVja2V0UHJvY2Vzc29yL0xpZmVjeWNsZUJ1Y2tldFByb2Nlc3Nvci5qcw==) | `79.48% <100.00%> (ø)` | | | [extensions/lifecycle/tasks/LifecycleTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=extensions%2Flifecycle%2Ftasks%2FLifecycleTask.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdGFza3MvTGlmZWN5Y2xlVGFzay5qcw==) | `88.82% <100.00%> (-0.02%)` | :arrow_down: | | [extensions/lifecycle/util/rules.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=extensions%2Flifecycle%2Futil%2Frules.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdXRpbC9ydWxlcy5qcw==) | `100.00% <100.00%> (ø)` | | | [lib/config/configItems.joi.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=lib%2Fconfig%2FconfigItems.joi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL2NvbmZpZy9jb25maWdJdGVtcy5qb2kuanM=) | `96.15% <ø> (ø)` | | | [lib/constants.js](https://app.codecov.io/gh/scality/backbeat/pull/2548?src=pr&el=tree&filepath=lib%2Fconstants.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL2NvbnN0YW50cy5qcw==) | `100.00% <ø> (ø)` | | | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.11% <ø> (ø)` | | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `76.06% <100.00%> (-0.01%)` | :arrow_down: | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.54% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2548/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.7 #2548 +/- ## =================================================== - Coverage 70.25% 70.24% -0.01% =================================================== Files 194 194 Lines 12955 12954 -1 =================================================== - Hits 9101 9100 -1 Misses 3844 3844 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.73% <25.00%> (+<0.01%)` | :arrow_up: | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.54% <25.00%> (+<0.01%)` | :arrow_up: | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.47% <25.00%> (+<0.01%)` | :arrow_up: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.50% <25.00%> (+<0.01%)` | :arrow_up: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.24% <100.00%> (-0.01%)` | :arrow_down: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.88% <0.00%> (+<0.01%)` | :arrow_up: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `18.87% <25.00%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `46.44% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 3 weeks ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

KillianG commented 1 week ago

we might also want to add the new field to conf/config.json no ?