search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
55 stars 19 forks source link

Improvement/bb 541 avoid initializing mongodb client #2553

Closed benzekrimaha closed 1 month ago

benzekrimaha commented 1 month ago

Issue : BB-541

bert-e commented 1 month ago

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 1 month ago

Incorrect fix version

The Fix Version/s in issue BB-541 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-541, or the target branch of this pull request.

bert-e commented 1 month ago

Incorrect fix version

The Fix Version/s in issue BB-541 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-541, or the target branch of this pull request.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.86%. Comparing base (31d9ca6) to head (d19fbd5). Report is 2 commits behind head on development/8.7.

Files with missing lines Patch % Lines
lib/api/BackbeatAPI.js 94.44% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2553/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2553?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [lib/api/BackbeatAPI.js](https://app.codecov.io/gh/scality/backbeat/pull/2553?src=pr&el=tree&filepath=lib%2Fapi%2FBackbeatAPI.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL2FwaS9CYWNrYmVhdEFQSS5qcw==) | `89.87% <94.44%> (+0.46%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `74.38% <94.44%> (+0.24%)` | :arrow_up: | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.83% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.42% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2553/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (-0.16%)` | :arrow_down: | ```diff @@ Coverage Diff @@ ## development/8.7 #2553 +/- ## =================================================== + Coverage 69.67% 69.86% +0.19% =================================================== Files 194 194 Lines 12819 12897 +78 =================================================== + Hits 8931 9010 +79 + Misses 3878 3877 -1 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.65% <66.66%> (+0.01%)` | :arrow_up: | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.54% <66.66%> (+0.01%)` | :arrow_up: | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (-0.16%)` | :arrow_down: | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.48% <0.00%> (-0.01%)` | :arrow_down: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.52% <0.00%> (-0.02%)` | :arrow_down: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.32% <0.00%> (-0.01%)` | :arrow_down: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.88% <0.00%> (-0.01%)` | :arrow_down: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.00% <0.00%> (+0.08%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2553/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `44.85% <77.77%> (+0.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
benzekrimaha commented 1 month ago

/approve

bert-e commented 1 month ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-541.

Goodbye benzekrimaha.

The following options are set: approve