search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
55 stars 19 forks source link

dataMoverTopic not required anymore and defaults to empty string #2554

Closed KillianG closed 4 weeks ago

KillianG commented 1 month ago

Do not create a consumer if no topic provided

Issue: BB-565

bert-e commented 1 month ago

Hello killiang,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 1 month ago

Incorrect fix version

The Fix Version/s in issue BB-565 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-565, or the target branch of this pull request.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.28%. Comparing base (1540d41) to head (1e7517f). Report is 7 commits behind head on development/8.7.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2554/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2554?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [...tensions/replication/ReplicationConfigValidator.js](https://app.codecov.io/gh/scality/backbeat/pull/2554?src=pr&el=tree&filepath=extensions%2Freplication%2FReplicationConfigValidator.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi9SZXBsaWNhdGlvbkNvbmZpZ1ZhbGlkYXRvci5qcw==) | `60.00% <ø> (ø)` | | | [...sions/replication/queueProcessor/QueueProcessor.js](https://app.codecov.io/gh/scality/backbeat/pull/2554?src=pr&el=tree&filepath=extensions%2Freplication%2FqueueProcessor%2FQueueProcessor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi9xdWV1ZVByb2Nlc3Nvci9RdWV1ZVByb2Nlc3Nvci5qcw==) | `72.96% <100.00%> (ø)` | | | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.12% <ø> (ø)` | | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `76.20% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.57% <100.00%> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2554/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.7 #2554 +/- ## ================================================ Coverage 70.28% 70.28% ================================================ Files 194 194 Lines 12965 12965 ================================================ Hits 9113 9113 Misses 3842 3842 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.75% <0.00%> (ø)` | | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.56% <0.00%> (ø)` | | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.48% <0.00%> (ø)` | | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.52% <0.00%> (ø)` | | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.28% <0.00%> (ø)` | | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.88% <0.00%> (ø)` | | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `18.90% <100.00%> (ø)` | | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `46.68% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 1 month ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

bert-e commented 4 weeks ago

Conflict

There is a conflict between your branch improvement/BB-565-create-consumer-conditionally and the destination branch development/8.7.

Please resolve the conflict on the feature branch (improvement/BB-565-create-consumer-conditionally).

git fetch && \
git checkout origin/improvement/BB-565-create-consumer-conditionally && \
git merge origin/development/8.7

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-565-create-consumer-conditionally
bert-e commented 4 weeks ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

KillianG commented 4 weeks ago

/approve

bert-e commented 4 weeks ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-565.

Goodbye killiang.

The following options are set: approve