search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
55 stars 19 forks source link

Revert "use deleteObject to expire objects in S3c" #2570

Closed Kerkesni closed 2 weeks ago

Kerkesni commented 3 weeks ago

This reverts commit e2d61043936ddbd7ccf7ba43160f13cc1b9a14d6 which introduces logic to select which deletion API to use in expiration based on the backbeatClient API definition. This is useless since the unified backbeat will only be using the definition from. 8.x and that includes everything.

Added failback to deleteObject in case we use an older Cloudserver.

Issue: BB-617

bert-e commented 3 weeks ago

Hello kerkesni,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (6694ca8) to head (0ab64e0). Report is 42 commits behind head on development/8.7.

Files with missing lines Patch % Lines
...sions/lifecycle/tasks/LifecycleDeleteObjectTask.js 84.84% 5 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2570/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2570?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [...sions/lifecycle/tasks/LifecycleDeleteObjectTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2570?src=pr&el=tree&filepath=extensions%2Flifecycle%2Ftasks%2FLifecycleDeleteObjectTask.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9saWZlY3ljbGUvdGFza3MvTGlmZWN5Y2xlRGVsZXRlT2JqZWN0VGFzay5qcw==) | `92.51% <84.84%> (-1.43%)` | :arrow_down: | | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.14% <ø> (ø)` | | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `76.22% <84.84%> (+0.01%)` | :arrow_up: | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.79% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2570/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.7 #2570 +/- ## =================================================== + Coverage 70.31% 70.32% +0.01% =================================================== Files 194 194 Lines 12997 13012 +15 =================================================== + Hits 9139 9151 +12 - Misses 3848 3851 +3 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.71% <0.00%> (-0.02%)` | :arrow_down: | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.52% <0.00%> (-0.02%)` | :arrow_down: | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.43% <0.00%> (-0.02%)` | :arrow_down: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.49% <0.00%> (-0.01%)` | :arrow_down: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.25% <57.57%> (+0.01%)` | :arrow_up: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.87% <0.00%> (-0.01%)` | :arrow_down: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.01% <0.00%> (-0.03%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `46.66% <84.84%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 3 weeks ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

Kerkesni commented 2 weeks ago

/approve

bert-e commented 2 weeks ago

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

The following branches will NOT be impacted:

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

bert-e commented 2 weeks ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue BB-617.

Goodbye kerkesni.