Make probeserver config optional for bucket notification processes in S3C

[Kerkesni]

• validate() doesn't seem to validate the config at all, replaced it with joi.attempt() that we use to validate the extension configs.
• Moved the probeserver validation out of the probeserver startup function and into the joi config schema, as it can now be optional. undefined is now returned by the startup function when no probeserver config is provided. This case is already supported in the entrypoint files.
• In S3C, bucket notification processes only contain configuration for the notification extension. We make the probeserver config optional in this case as it is not currently supported in federation.

Issue: BB-623

[bert-e]

Hello kerkesni,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options

name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |

Available commands

name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.40%. Comparing base (6694ca8) to head (bb69b62). Report is 29 commits behind head on development/8.7.

Additional details and impacted files

[](https://app.codecov.io/gh/scality/backbeat/pull/2587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2587?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [...nsions/notification/NotificationConfigValidator.js](https://app.codecov.io/gh/scality/backbeat/pull/2587?src=pr&el=tree&filepath=extensions%2Fnotification%2FNotificationConfigValidator.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9ub3RpZmljYXRpb24vTm90aWZpY2F0aW9uQ29uZmlnVmFsaWRhdG9yLmpz) | `100.00% <ø> (+25.00%)` | :arrow_up: | | [lib/Config.js](https://app.codecov.io/gh/scality/backbeat/pull/2587?src=pr&el=tree&filepath=lib%2FConfig.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL0NvbmZpZy5qcw==) | `72.64% <100.00%> (+7.69%)` | :arrow_up: | | [lib/config.joi.js](https://app.codecov.io/gh/scality/backbeat/pull/2587?src=pr&el=tree&filepath=lib%2Fconfig.joi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL2NvbmZpZy5qb2kuanM=) | `100.00% <ø> (ø)` | | | [lib/util/probe.js](https://app.codecov.io/gh/scality/backbeat/pull/2587?src=pr&el=tree&filepath=lib%2Futil%2Fprobe.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3V0aWwvcHJvYmUuanM=) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2587/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `67.07% <ø> (+0.41%)` | :arrow_up: | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `75.32% <100.00%> (+0.18%)` | :arrow_up: | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `69.24% <ø> (ø)` | | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `76.20% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.79% <ø> (ø)` | | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2587/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.7 #2587 +/- ## =================================================== + Coverage 70.31% 70.40% +0.09% =================================================== Files 194 194 Lines 12997 12996 -1 =================================================== + Hits 9139 9150 +11 + Misses 3848 3836 -12 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.73% <75.00%> (+<0.01%)` | :arrow_up: | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.54% <75.00%> (+<0.01%)` | :arrow_up: | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.46% <75.00%> (+<0.01%)` | :arrow_up: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.52% <75.00%> (+0.01%)` | :arrow_up: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.24% <75.00%> (+<0.01%)` | :arrow_up: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.87% <0.00%> (+<0.01%)` | :arrow_up: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.04% <75.00%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `46.69% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.

[Kerkesni]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the relevant queue(s). The queue(s) will be merged in the target development branch(es) as soon as builds have passed.

The changeset will be merged in:

• :heavy_check_mark: development/8.7

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.5
• development/8.6

There is no action required on your side. You will be notified here once the changeset has been merged. In the unlikely event that the changeset fails permanently on the queue, a member of the admin team will contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request into targetted development branches:

• :heavy_check_mark: development/8.7

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.5
• development/8.6

Please check the status of the associated issue BB-623.

Goodbye kerkesni.