search

scality / backbeat

Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.
https://www.zenko.io
Apache License 2.0
55 stars 19 forks source link

Improvement/bb 614 remove redis metrics #2588

Open benzekrimaha opened 2 weeks ago

benzekrimaha commented 2 weeks ago

Issue : BB-614

bert-e commented 2 weeks ago

Hello benzekrimaha,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 2 weeks ago

Incorrect fix version

The Fix Version/s in issue BB-614 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-614, or the target branch of this pull request.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (6694ca8) to head (64450ba). Report is 36 commits behind head on development/8.7.

Files with missing lines Patch % Lines
lib/queuePopulator/BucketFileLogReader.js 0.00% 1 Missing :warning:
lib/queuePopulator/RaftLogReader.js 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scality/backbeat/pull/2588/graphs/tree.svg?width=650&height=150&src=pr&token=LlNB6ANurP&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality)](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Files with missing lines](https://app.codecov.io/gh/scality/backbeat/pull/2588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [extensions/mongoProcessor/MongoQueueProcessor.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2FmongoProcessor%2FMongoQueueProcessor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9tb25nb1Byb2Nlc3Nvci9Nb25nb1F1ZXVlUHJvY2Vzc29yLmpz) | `76.47% <100.00%> (+13.75%)` | :arrow_up: | | [...sions/replication/queueProcessor/QueueProcessor.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2FqueueProcessor%2FQueueProcessor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi9xdWV1ZVByb2Nlc3Nvci9RdWV1ZVByb2Nlc3Nvci5qcw==) | `73.11% <ø> (+0.14%)` | :arrow_up: | | [...ationStatusProcessor/ReplicationStatusProcessor.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2FreplicationStatusProcessor%2FReplicationStatusProcessor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi9yZXBsaWNhdGlvblN0YXR1c1Byb2Nlc3Nvci9SZXBsaWNhdGlvblN0YXR1c1Byb2Nlc3Nvci5qcw==) | `67.76% <ø> (-0.56%)` | :arrow_down: | | [extensions/replication/tasks/CopyLocationTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2Ftasks%2FCopyLocationTask.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi90YXNrcy9Db3B5TG9jYXRpb25UYXNrLmpz) | `63.38% <ø> (-0.54%)` | :arrow_down: | | [...xtensions/replication/tasks/MultipleBackendTask.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2Ftasks%2FMultipleBackendTask.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi90YXNrcy9NdWx0aXBsZUJhY2tlbmRUYXNrLmpz) | `53.57% <ø> (+0.28%)` | :arrow_up: | | [extensions/replication/tasks/ReplicateObject.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2Ftasks%2FReplicateObject.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi90YXNrcy9SZXBsaWNhdGVPYmplY3QuanM=) | `91.36% <100.00%> (-0.13%)` | :arrow_down: | | [...sions/replication/tasks/UpdateReplicationStatus.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=extensions%2Freplication%2Ftasks%2FUpdateReplicationStatus.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-ZXh0ZW5zaW9ucy9yZXBsaWNhdGlvbi90YXNrcy9VcGRhdGVSZXBsaWNhdGlvblN0YXR1cy5qcw==) | `77.19% <ø> (-1.31%)` | :arrow_down: | | [lib/queuePopulator/IngestionPopulator.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=lib%2FqueuePopulator%2FIngestionPopulator.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3F1ZXVlUG9wdWxhdG9yL0luZ2VzdGlvblBvcHVsYXRvci5qcw==) | `69.56% <ø> (+2.67%)` | :arrow_up: | | [lib/queuePopulator/IngestionReader.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=lib%2FqueuePopulator%2FIngestionReader.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3F1ZXVlUG9wdWxhdG9yL0luZ2VzdGlvblJlYWRlci5qcw==) | `80.88% <100.00%> (-0.73%)` | :arrow_down: | | [lib/queuePopulator/KafkaLogReader.js](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree&filepath=lib%2FqueuePopulator%2FKafkaLogReader.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#diff-bGliL3F1ZXVlUG9wdWxhdG9yL0thZmthTG9nUmVhZGVyLmpz) | `100.00% <100.00%> (+81.25%)` | :arrow_up: | | ... and [5 more](https://app.codecov.io/gh/scality/backbeat/pull/2588?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/scality/backbeat/pull/2588/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | [Components](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [Bucket Notification](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `66.66% <ø> (ø)` | | | [Core Library](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `77.15% <60.00%> (+2.01%)` | :arrow_up: | | [Ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `72.09% <100.00%> (+2.85%)` | :arrow_up: | | [Lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `76.20% <ø> (ø)` | | | [Oplog Populator](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `82.95% <ø> (ø)` | | | [Replication](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `57.15% <100.00%> (-0.64%)` | :arrow_down: | | [Bucket Scanner](https://app.codecov.io/gh/scality/backbeat/pull/2588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | ```diff @@ Coverage Diff @@ ## development/8.7 #2588 +/- ## =================================================== + Coverage 70.31% 71.19% +0.88% =================================================== Files 194 192 -2 Lines 12997 12722 -275 =================================================== - Hits 9139 9058 -81 + Misses 3848 3654 -194 Partials 10 10 ``` | [Flag](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api:retry](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.94% <0.00%> (+0.21%)` | :arrow_up: | | [api:routes](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `9.74% <0.00%> (+0.21%)` | :arrow_up: | | [bucket-scanner](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `85.60% <ø> (ø)` | | | [ingestion](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `12.17% <7.14%> (-0.29%)` | :arrow_down: | | [lib](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `7.67% <0.00%> (+0.16%)` | :arrow_up: | | [lifecycle](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `19.66% <0.00%> (+0.42%)` | :arrow_up: | | [notification](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `0.89% <0.00%> (+0.01%)` | :arrow_up: | | [replication](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `18.46% <7.14%> (-0.57%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/scality/backbeat/pull/2588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `47.98% <85.71%> (+1.37%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.
bert-e commented 6 days ago

Incorrect fix version

The Fix Version/s in issue BB-614 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of BB-614, or the target branch of this pull request.

bert-e commented 6 hours ago

Branches have diverged

This pull request's source branch improvement/BB-614-remove-redis-metrics has diverged from development/9.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the following solutions:

Note: If you choose to rebase, you may have to ask me to rebuild integration branches using the reset command.