search

scality / cloudserver

Zenko CloudServer, an open-source Node.js implementation of the Amazon S3 protocol on the front-end and backend storage capabilities to multiple clouds, including Azure and Google.
https://www.zenko.io/cloudserver
Apache License 2.0
1.71k stars 241 forks source link

Bugfix/cldsrv 531 delete lifecycle ignored #5568

Closed KazToozs closed 5 months ago

KazToozs commented 5 months ago

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change as soon as we can.

bert-e commented 5 months ago

Hello kaztoozs,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 5 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of CLDSRV-531, or the target branch of this pull request.

KazToozs commented 5 months ago

/approve

bert-e commented 5 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of CLDSRV-531, or the target branch of this pull request.

The following options are set: approve

KazToozs commented 5 months ago

/help

bert-e commented 5 months ago

Help page

The following options and commands are available at this time.

Options

name description privileged authored
:arrow_right: after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
:arrow_right: bypass_author_approval Bypass the pull request author's approval :star:
:arrow_right: bypass_build_status Bypass the build and test status :star:
:arrow_right: bypass_commit_size Bypass the check on the size of the changeset TBA :star:
:arrow_right: bypass_incompatible_branch Bypass the check on the source branch prefix :star:
:arrow_right: bypass_jira_check Bypass the Jira issue check :star:
:arrow_right: bypass_peer_approval Bypass the pull request peers' approval :star:
:arrow_right: bypass_leader_approval Bypass the pull request leaders' approval :star:
:arrow_right: approve Instruct Bert-E that the author has approved the pull request. :writing_hand:
:arrow_right: create_pull_requests Allow the creation of integration pull requests.
:arrow_right: create_integration_branches Allow the creation of integration branches.
:arrow_right: no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
:arrow_right: unanimity Change review acceptance criteria from one reviewer at least to all reviewers
:arrow_right: wait Instruct Bert-E not to run until further notice.

Commands

name description privileged
:arrow_right: help Print Bert-E's manual in the pull request.
:arrow_right: status Print Bert-E's current status in the pull request TBA
:arrow_right: clear Remove all comments from Bert-E from the history TBA
:arrow_right: retry Re-start a fresh build TBA
:arrow_right: build Re-start a fresh build TBA
:arrow_right: force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
:arrow_right: reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

The following options are set: approve

bert-e commented 5 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of CLDSRV-531, or the target branch of this pull request.

The following options are set: approve

KazToozs commented 5 months ago

ping

bert-e commented 5 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of CLDSRV-531, or the target branch of this pull request.

The following options are set: approve

bert-e commented 5 months ago

Not authorized

I'm afraid I cannot do that, @kaztoozs:

/bypass_jira_check

You cannot use bypass_jira_check in your own pull request.

Please edit or delete the corresponding comment so I can move on.

The following options are set: approve

bert-e commented 5 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-531 contains:

Considering where you are trying to merge, I expected to find at least:

Please check the Fix Version/s of CLDSRV-531, or the target branch of this pull request.

The following options are set: approve

anurag4DSB commented 5 months ago

/bypass_jira_check

bert-e commented 5 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue CLDSRV-531.

Goodbye kaztoozs.

The following options are set: bypass_jira_check, approve