search

scality / cloudserver

Zenko CloudServer, an open-source Node.js implementation of the Amazon S3 protocol on the front-end and backend storage capabilities to multiple clouds, including Azure and Google.
https://www.zenko.io/cloudserver
Apache License 2.0
1.68k stars 236 forks source link

bf: CLDSRV-547 update redis config for utapi reindex #5602

Closed jonathan-gramain closed 2 months ago

jonathan-gramain commented 2 months ago

Update the redis configuration of utapi reindex to include a list of sentinels, rather than a single sentinel (previously set to "localhost" in Federation).

I took this opportunity to cleanup tech debt related to parsing redis configuration, using "joi" for validation instead and making it common across the three different places where redis config is parsed. Not doing so would have required yet another copy-paste of dumb and error-prone validation code. Added unit tests for the new validation.

bert-e commented 2 months ago

Hello jonathan-gramain,

My role is to assist you with the merge of this pull request. Please type @bert-e help to get information on this process, or consult the user documentation.

Available options name | description | privileged | authored ------ | ------------ | ------------ |---------- `/after_pull_request` | Wait for the given pull request id to be merged before continuing with the current one. | | `/bypass_author_approval` | Bypass the pull request author's approval | :star: | `/bypass_build_status` | Bypass the build and test status | :star: | `/bypass_commit_size` | Bypass the check on the size of the changeset ```TBA``` | :star: | `/bypass_incompatible_branch` | Bypass the check on the source branch prefix | :star: | `/bypass_jira_check` | Bypass the Jira issue check | :star: | `/bypass_peer_approval` | Bypass the pull request peers' approval | :star: | `/bypass_leader_approval` | Bypass the pull request leaders' approval | :star: | `/approve` | Instruct Bert-E that the author has approved the pull request. | | :writing_hand: `/create_pull_requests` | Allow the creation of integration pull requests. | | `/create_integration_branches` | Allow the creation of integration branches. | | `/no_octopus` | Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead | | `/unanimity` | Change review acceptance criteria from `one reviewer at least` to `all reviewers` | | `/wait` | Instruct Bert-E not to run until further notice. | |
Available commands name | description | privileged ------ | ------------ | ------------ `/help` | Print Bert-E's manual in the pull request. | `/status` | Print Bert-E's current status in the pull request ```TBA``` | `/clear` | Remove all comments from Bert-E from the history ```TBA``` | `/retry` | Re-start a fresh build ```TBA``` | `/build` | Re-start a fresh build ```TBA``` | `/force_reset` | Delete integration branches & pull requests, and restart merge process from the beginning. | `/reset` | Try to remove integration branches unless there are commits on them which do not appear on the source branch. |

Status report is not available.

bert-e commented 2 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-547 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of CLDSRV-547, or the target branch of this pull request.

jonathan-gramain commented 2 months ago

ping

bert-e commented 2 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

bert-e commented 2 months ago

Incorrect fix version

The Fix Version/s in issue CLDSRV-547 contains:

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

Please check the Fix Version/s of CLDSRV-547, or the target branch of this pull request.

bert-e commented 2 months ago

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically create the integration branches.

jonathan-gramain commented 2 months ago

/create_integration_branches

bert-e commented 2 months ago

Conflict

A conflict has been raised during the creation of integration branch w/7.70/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex with contents from bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex and development/7.70.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/7.70/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex origin/development/7.70
 $ git merge origin/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/7.70/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex

The following options are set: create_integration_branches

bert-e commented 2 months ago

Conflict

A conflict has been raised during the creation of integration branch w/8.6/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex with contents from w/7.70/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex and development/8.6.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.6/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex origin/development/8.6
 $ git merge origin/w/7.70/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.6/bugfix/CLDSRV-547-updateRedisConfigForUtapiReindex

The following options are set: create_integration_branches

bert-e commented 2 months ago

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

You can set option create_pull_requests if you need me to create integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e commented 2 months ago

Waiting for approval

The following approvals are needed before I can proceed with the merge:

The following options are set: create_integration_branches

jonathan-gramain commented 2 months ago

/approve

bert-e commented 2 months ago

I have successfully merged the changeset of this pull request into targetted development branches:

The following branches have NOT changed:

Please check the status of the associated issue CLDSRV-547.

Goodbye jonathan-gramain.

The following options are set: approve, create_integration_branches