Closed benzekrimaha closed 1 month ago
My role is to assist you with the merge of this
pull request. Please type @bert-e help
to get information
on this process, or consult the user documentation.
Status report is not available.
The following approvals are needed before I can proceed with the merge:
the author
2 peers
@anurag4DSB 7.x branches are not concerned by this fixup as the https://github.com/scality/cloudserver/pull/5580 was merged in 8.8 only
@benzekrimaha we can indeed backport this fix and have it in 7.x branches, if we also pass the implicit flag in there, as we might end up with the same problem if we implement quotas with scuba at some point, even if the bug is not (yet) in 7.x
PR will be merged starting 7.10
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches
Alternatively, the /approve
and /create_pull_requests
commands will automatically
create the integration branches.
/create_integration_branches
I have created the integration data for the additional destination branches.
bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
into
development/7.10
development/7.70
development/8.6
development/8.7
development/8.8
The following branches will NOT be impacted:
development/7.4
You can set option create_pull_requests
if you need me to create
integration pull requests in addition to integration branches, with:
@bert-e create_pull_requests
The following options are set: create_integration_branches
The following approvals are needed before I can proceed with the merge:
the author
2 peers
The following options are set: create_integration_branches
@bert-e create_pull_requests
I have created the integration data for the additional destination branches.
bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
into
development/7.10
development/7.70
(pull request #5627)development/8.6
(pull request #5628)development/8.7
(pull request #5629)development/8.8
(pull request #5630)The following branches will NOT be impacted:
development/7.4
Follow integration pull requests if you would like to be notified of build statuses by email.
The following options are set: create_pull_requests, create_integration_branches
The following approvals are needed before I can proceed with the merge:
the author
2 peers
The following options are set: create_pull_requests, create_integration_branches
@bert-e reset
I have successfully deleted this pull request's integration branches.
The following options are set: create_pull_requests, create_integration_branches
/create_integration_branches
I have created the integration data for the additional destination branches.
bugfix/CLDSRV-555-deleteObjects-policy-eval-fix
into
development/7.10
development/7.70
(pull request #5631)development/8.6
(pull request #5632)development/8.7
(pull request #5633)development/8.8
(pull request #5634)The following branches will NOT be impacted:
development/7.4
Follow integration pull requests if you would like to be notified of build statuses by email.
The following options are set: create_pull_requests, create_integration_branches
The following approvals are needed before I can proceed with the merge:
the author
2 peers
The following options are set: create_pull_requests, create_integration_branches
/approve
I have successfully merged the changeset of this pull request into targetted development branches:
:heavy_check_mark: development/7.10
:heavy_check_mark: development/7.70
:heavy_check_mark: development/8.6
:heavy_check_mark: development/8.7
:heavy_check_mark: development/8.8
The following branches have NOT changed:
development/7.4
Please check the status of the associated issue CLDSRV-555.
Goodbye benzekrimaha.
The following options are set: approve, create_pull_requests, create_integration_branches
Introduced by https://github.com/scality/cloudserver/pull/5580 we now do send a requestContext with no specific resource instead of "null", which results in a policy evaluation error. As we get an implicit deny for the requestType "objectDelete", causing the processed result to be false , thus sending an empty array of objects to vault , resulting in a deny even when the policy allows the action on specific objects.
Linked Issue : https://scality.atlassian.net/browse/CLDSRV-555