scality / metalk8s

An opinionated Kubernetes distribution with a focus on long-term on-prem deployments
Apache License 2.0
350 stars 44 forks source link

Grafana plugins should be customizable #2611

Open gdemonet opened 4 years ago

gdemonet commented 4 years ago

Component: build, monitoring

Current situation:

In recent versions (6+), grafana/grafana container image doesn't come with the grafana-piechart-panel plugin installed. To make sure we had this plugin installed by default in our deployment without requiring an online installation at runtime, we baked our own image with this plugin installed at build-time.

This approach is sufficient for handling the dashboards we embed with MetalK8s releases. It will not be sufficient for handling user-provided dashboards or anything shipped with Solution archives (see #1860).

Proposed solution:

To be detailed, but first investigations led to the following conclusions:

NicolasT commented 4 years ago

I'm not sure we should go as far, at least for now. The plugins required for dashboard included in MetalK8s can be included as they are now. For Scality solutions, they can be added per request in a MetalK8s release (do we foresee a lot of them would be needed?).

gdemonet commented 4 years ago

I'm more concerned for users willing to deploy/build their own dashboards (and have no clue how many plugins would be required).

thomasdanan commented 3 years ago

We need to have a proper solution to manage user custos (like creating dashboards) without requesting additional CLI steps. It seems that the best approach to have customization persistence, HA, and maybe leverage the Grafana annotation feature is having a real DB behind Grafana (to be confirmed)

gdemonet commented 3 years ago

@thomasdanan This issue is about custom plugins, which is a different topic from what you are discussing here, which is persisting changes done in Grafana UI. Let's open a different ticket for tracking this (edit: opened #2851).