search

scality / quadiron

Fast Erasure Coding Library for Large Number of Data and Parities
BSD 3-Clause "New" or "Revised" License
28 stars 5 forks source link

simplify the compile time option #242

Closed slaperche-scality closed 5 years ago

slaperche-scality commented 5 years ago

Instead of defining our own constants, we can use the "standard" ones defined by the compiler.

Also, we don't need to infer the best SIMD instructions set on the current machine by ourself: this can be done with -march=native.

Refs: #222

slaperche-scality commented 5 years ago

Do you test it on a machine that does not support AVX?

My laptop support AVX, but we do test the compilation without AVX (on Android). Why?

slaperche-scality commented 5 years ago

@lamphamsy I kept QUADIRON_USE_SIMD because it's used to check if SIMD is enabled (that way we only have to check this one instead of checking if(SSE OR AVX OR AVX512 OR NEON), so it's convenient.

I only removed QUADIRON_USE_AVX2 and QUADIRON_USE_SSE4.