search

scality / runner-manager

Service to manage github Actions self-hosted runners
https://scality.github.io/runner-manager/
Apache License 2.0
7 stars 7 forks source link

poetry: add auth-app extra to githubkit #552

Closed harryfinbow closed 4 months ago

harryfinbow commented 4 months ago

Using GitHub App authentication causes the worker to crash on startup with following error: RuntimeError: JWT support for GitHub APP should be installed with 'pip install githubkit[auth-app]'

Adding the auth-app extra to the githubkit Python package fixes this by allowing the worker to authenticate to GitHub using both token and app auth.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.96%. Comparing base (6d0e6e4) to head (ed26c7f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #552 +/- ## =========================================== + Coverage 67.71% 85.96% +18.24% =========================================== Files 31 31 Lines 1211 1211 =========================================== + Hits 820 1041 +221 + Misses 391 170 -221 ``` | [Flag](https://app.codecov.io/gh/scality/runner-manager/pull/552/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/scality/runner-manager/pull/552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `67.71% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/scality/runner-manager/pull/552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `70.93% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tcarmet commented 4 months ago

Was able to get a successful build but had failures due to the fact that PR coming from open source contributions do not have permissions to push on ghcr under the ghcr.io/scality/runnner-manager namespace:

ERROR: failed to solve: failed to push ghcr.io/scality/runner-manager:dff956ffbd0aae0d1072f2bf8c53a635c52e74ca: unexpected status from POST request to https://ghcr.io/v2/scality/runner-manager/blobs/uploads/: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/scality/runner-manager:dff956ffbd0aae0d1072f2bf8c53a635c52e74ca: unexpected status from POST request to https://ghcr.io/v2/scality/runner-manager/blobs/uploads/: 403 Forbidden

Which is fine and given the workflow configuration, expected. So we are good to merge 🚀

Thanks again for your contribution @harryfinbow!