scality / runner-manager

Service to manage github Actions self-hosted runners
https://scality.github.io/runner-manager/
Apache License 2.0
6 stars 5 forks source link

PTFE-1798 handling errors of no such index #617

Closed tcarmet closed 1 month ago

tcarmet commented 1 month ago

If the redis instance happens to reboot during the runtime of the runner manager, redis will need for the Migrator().run() function to run to re-create the indexes. Otherwise we will face an interruption of service with the error:

redis.exceptions.ResponseError: runner-manager:runner_manager.models.runner_group.RunnerGroup:index: no such index

The following actions were taken in the code:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.21%. Comparing base (ba90755) to head (c5e8b95). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #617 +/- ## ========================================== - Coverage 86.38% 86.21% -0.17% ========================================== Files 33 33 Lines 1381 1386 +5 ========================================== + Hits 1193 1195 +2 - Misses 188 191 +3 ``` | [Flag](https://app.codecov.io/gh/scality/runner-manager/pull/617/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/scality/runner-manager/pull/617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `63.85% <88.88%> (+0.13%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/scality/runner-manager/pull/617/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality) | `68.54% <44.44%> (-0.33%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scality#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.