store.add(): a new kwargs was added.

scality / scality-glance-store

Glance backend for Scality

Apache License 2.0

0 stars 0 forks source link

store.add(): a new kwargs was added. #27

Closed JordanP closed 8 years ago

JordanP commented 8 years ago

Commit 1 in glance_store added a new kwarg argument to the add method of the drivers. We need to update our driver.

This got unoticed so far because the global-requirements in OpenStack capped glance-store to 0.10.0. This commit 2 bumped the global-requirement which reveiled our incompatibility.

NicolasT commented 8 years ago

Consider adding a small test calling add without passing a verifier, and ensuring everything still works (to test backwards compatibility)?

JordanP commented 8 years ago

We have already test_add_with_response_412 and test_add_with_response_500 that calls this add method without a verifier. I don"t know how to add a new test case (this time without a verifier) without basically duplicating the current test_add code.

sbjorn commented 8 years ago

LGTM

NicolasT commented 8 years ago

LGTM