scallop-lang / scallop

Framework and Language for Neurosymbolic Programming.
https://www.scallop-lang.org
MIT License
201 stars 8 forks source link

Installer not Functional #10

Closed ludgerpaehler closed 1 year ago

ludgerpaehler commented 1 year ago

When attempting to install Scallop's scli on an M1 Mac, as well as on a x86-system, I have in both instances hit the following error:

error[E0635]: unknown feature `drain_filter`
 --> core/src/lib.rs:2:12
  |
2 | #![feature(drain_filter)]
  |            ^^^^^^^^^^^^

error[E0599]: no method named `drain_filter` found for struct `Vec<NegativeDataflow>` in the current scope
   --> core/src/compiler/back/b2r.rs:126:10
    |
125 |         let curr_neg_dfs = negative_dataflows
    |  __________________________-
126 | |         .drain_filter(|ndf| ndf.sources.is_subset(&accumulated_sources))
    | |         -^^^^^^^^^^^^ method not found in `Vec<NegativeDataflow>`
    | |_________|
    |

Some errors have detailed explanations: E0599, E0635.
For more information about an error, try `rustc --explain E0599`.
error: could not compile `scallop-core` (lib) due to 2 previous errors
error: failed to compile `scli v0.1.9 (/local/temp/Scallop-Devving/scallop/etc/scli)`, intermediate artifacts can be found at `/local/temp/Scallop-Devving/scallop/target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
make: *** [makefile:5: install-scli] Error 101

In both instances the use of Rust's nightly repositories is set up correctly, and the right compilers seem to be used.

Liby99 commented 1 year ago

This was due to rust nightly channel introducing breaking changes to APIs. This is fixed in the latest commit.

ludgerpaehler commented 1 year ago

Thank for fixing it so fast!!!! It works for me now :)