Closed scalvert closed 5 years ago
CI failure is:
$ find lib src node-tests/unit -name '*.js' -type f -delete
find: `lib': No such file or directory
Yep. I'm still working out the right structure for this. The issues are:
lib
to src
means that tests that were previously referencing code from lib
will error if lib
isn't compiledsrc
-lib
output. This feels dirtyI'm trying to figure out a nicer way I can compile to lib
using yarn build
, and just have the tests reference the code there. There are obvious issues with this as the TS interfaces don't get compiled, so in tests some paths are referencing src
(for type info) and some are referencing lib
. This feels messy.
Let's chat offline about it?
One option is to nerf the tsconfig.json
in tests, and let the node-tests
get compiled into lib
with the src
. This would allow us to do
yarn build && qunit lib/node-tests && yarn clean
This doesn't solve if the tests fail and the cleanup doesn't occur. We'd still need to fix this using a custom bash script or a trap.
Fixes #28