scalvert / ember-cli-checkup

An Ember CLI addon that provides health check information about your application, engine, or addon.
MIT License
7 stars 1 forks source link

task(project): Restructures project to use src dir to prevent comingling of output #39

Closed scalvert closed 5 years ago

scalvert commented 5 years ago

Fixes #28

rwjblue commented 5 years ago

CI failure is:

$ find lib src node-tests/unit -name '*.js' -type f -delete
find: `lib': No such file or directory
scalvert commented 5 years ago

Yep. I'm still working out the right structure for this. The issues are:

I'm trying to figure out a nicer way I can compile to lib using yarn build, and just have the tests reference the code there. There are obvious issues with this as the TS interfaces don't get compiled, so in tests some paths are referencing src (for type info) and some are referencing lib. This feels messy.

Let's chat offline about it?

scalvert commented 5 years ago

One option is to nerf the tsconfig.json in tests, and let the node-tests get compiled into lib with the src. This would allow us to do

yarn build && qunit lib/node-tests && yarn clean

This doesn't solve if the tests fail and the cleanup doesn't occur. We'd still need to fix this using a custom bash script or a trap.