scalyr / dataset-addon-for-splunk

The DataSet Add-on for Splunk provides integration with
Apache License 2.0
4 stars 6 forks source link

DPDV-2403 style: reformat code and imports #39

Closed zdaratom-s1 closed 1 year ago

zdaratom-s1 commented 1 year ago

Jira Link: https://sentinelone.atlassian.net/browse/DPDV-2403

🛠️ Description

🏫 Testing

Verified on local dev docker

martin-majlis-s1 commented 1 year ago

My plan was to enforce it and reformat using the pre-commit hooks - https://pre-commit.com - so that it's enforced during every build

repos:
-   repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.4.0
    hooks:
    -   id: check-yaml
    -   id: end-of-file-fixer
    -   id: trailing-whitespace
-   repo: https://github.com/psf/black
    rev: 23.7.0
    hooks:
    -   id: black
  - repo: https://github.com/pycqa/isort
    rev: 5.11.2
    hooks:
      - id: isort
        name: isort (python)
zdaratom-s1 commented 1 year ago

That is not mentioned in the https://sentinelone.atlassian.net/browse/DPDV-2403 "Reformat all the code with black and isort"

Anyway pre-commit will take place on developer side before commit, we still need to reformat code in repository. And ratgher do it in separate PR then together with some feature/bugfix