scalyr / dataset-addon-for-splunk

The DataSet Add-on for Splunk provides integration with
Apache License 2.0
3 stars 10 forks source link

[DPDV-3497] Upgrade splunk-appinspect to the latest stable version, fix lint #86

Closed tomaz-s1 closed 11 months ago

tomaz-s1 commented 11 months ago

This pull request updates splunk-appinspect to the latest stable version (v2.37.2) which includes latest fixes.

Keep in mind that this release doesn't include a fix for pillow CVE yet, since it still depends on pillow==9.5.0.

Changelog file: https://dev.splunk.com/enterprise/docs/relnotes/relnotes-appinspectcli/whatsnew/#v23722023-09-14

tomaz-s1 commented 11 months ago

Playwright tests are failing, but I don't think it's related to any of my changes since I see they are also failing in other branches (https://github.com/scalyr/dataset-addon-for-splunk/actions/workflows/playwright.yml) - likely flaky / non-reliable test or similar.

tomaz-s1 commented 11 months ago

OK, I think I see the reason why the tests are failing - it's related to the rename and some elements text changing. I will try to fix failing e2e tests as well.

tomaz-s1 commented 11 months ago

The following PRs broke end to end tests:

I decided to merge this PR as-is (only update dependencies) and then handle fixing end to end tests as part of a separate PR.

This means e2e tests will continue to fail until those have been fixed in the future PR.