search

scalyr / dataset-addon-for-splunk

The DataSet Add-on for Splunk provides integration with
Apache License 2.0
4 stars 6 forks source link

Update workflows to use "concurrency" GHA functionality to skip redundant workflow runs #88

Closed tomaz-s1 closed 1 year ago

tomaz-s1 commented 1 year ago

This pull request updates GHA workflow to utilize "concurrency" functionality so we skip / cancel redundant build runs for non-main branch workflow runs.

Relying on this native functionality instead of on skip-duplicate-jobs also allows to to reduce permissions we need for workflow runs.

tomaz-s1 commented 1 year ago

I also pushed some changes which will hopefully make New Input - DataSet Alerts test less flaky.

Since alert evaluation and alert state reporting only happens every 1 minute, it means we need to wait at least 2-3 minutes after creating an alert input before checking for results otherwise there is a high chance of a failure.

It's worth noting that Playwright level retry won't do nothing in this situation since it simply retries the whole test.