scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 60 forks source link

DTIN-3080: Windows Agent permission error #1188

Closed jmakar-s1 closed 11 months ago

jmakar-s1 commented 1 year ago

Allow WindowsPlatformController.run_as_user to execute as any Administrator account

Did not fiddle with (ie replace) the existing logic around __local_administrators because of its unrelated usage in get_file_owner & get_current_user

github-actions[bot] commented 1 year ago

Test Results

     28 files  ±0       28 suites  ±0   47m 37s :stopwatch: - 1m 58s 1 448 tests +1  1 423 :heavy_check_mark: +1    25 :zzz: ±0  0 :x: ±0  9 761 runs  +1  9 468 :heavy_check_mark: +1  293 :zzz: ±0  0 :x: ±0 

Results for commit 16e687ae. ± Comparison against base commit dd7716fe.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1188 (16e687a) into master (dd7716f) will increase coverage by 3.62%. Report is 3 commits behind head on master. The diff coverage is 94.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
+ Coverage   77.61%   81.22%   +3.62%     
==========================================
  Files         173      173              
  Lines       41867    41898      +31     
  Branches     4682     4685       +3     
==========================================
+ Hits        32491    34030    +1539     
+ Misses       8339     6651    -1688     
- Partials     1037     1217     +180     
Files Changed Coverage Δ
scalyr_agent/platform_windows.py 45.99% <89.29%> (+2.52%) :arrow_up:
tests/unit/test_platform_windows.py 97.78% <100.00%> (+1.23%) :arrow_up:

... and 24 files with indirect coverage changes

alesnovak-s1 commented 1 year ago

@jmakar-scalyr You can ignore the failing tests. They will be fixed in the next PR: https://github.com/scalyr/scalyr-agent-2/pull/1189