scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 60 forks source link

DTIN-3193: Install ca-certificates in runtime_base image #1214

Closed jmakar-s1 closed 10 months ago

jmakar-s1 commented 10 months ago

Install ca-certificates in runtime_base image to populate /etc/ssl/certs, this resolves issue #1199

Before

$ docker run -it scalyr/scalyr-k8s-agent:2.2.4 ls /etc/ssl/certs
ls: cannot access '/etc/ssl/certs': No such file or directory

After

$ docker run -it test4scalyr/scalyr-k8s-agent:dtin-3193 ls /etc/ssl/certs/*.pem | wc -l
141
$ docker run -it test4scalyr/scalyr-k8s-agent:dtin-3193 python3 -c 'import urllib.request; print(urllib.request.urlopen("https://google.de").status)'
200
github-actions[bot] commented 10 months ago

Test Results

     19 files   -   1       19 suites   - 1   26m 23s :stopwatch: - 6m 11s 1 427 tests  - 21  1 402 :heavy_check_mark:  - 21    25 :zzz: ±0  0 :x: ±0  6 898 runs   - 21  6 668 :heavy_check_mark:  - 21  230 :zzz: ±0  0 :x: ±0 

Results for commit ef09f431. ± Comparison against base commit 596cab27.

This pull request removes 21 tests. ``` tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python2 tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python2_host tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python2_ssl tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python2_ssl_bad_cafile tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python2_ssl_bad_hostname tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python3 tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python3_host tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python3_ssl tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python3_ssl_bad_cafile tests.smoke_tests.monitors_test.mysql_test ‑ test_mysql_python3_ssl_bad_hostname … ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 10 months ago

Codecov Report

Merging #1214 (8733530) into master (596cab2) will decrease coverage by 25.97%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1214       +/-   ##
===========================================
- Coverage   81.41%   55.44%   -25.97%     
===========================================
  Files         174       51      -123     
  Lines       42053    18272    -23781     
  Branches     4699     3238     -1461     
===========================================
- Hits        34234    10130    -24104     
- Misses       6604     6961      +357     
+ Partials     1215     1181       -34     

see 167 files with indirect coverage changes