scalyr / scalyr-agent-2

The source code for Scalyr Agent 2, the daemon process Scalyr customers run on their servers to collect metrics and logs.
Apache License 2.0
70 stars 60 forks source link

DTIN-3315 #1223

Closed alesnovak-s1 closed 8 months ago

alesnovak-s1 commented 9 months ago

https://sentinelone.atlassian.net/browse/DTIN-3315

CRI logs - partial lines support.

Partial and final lines are marked by P and F tags respectively. Note that the timestamp of the matching message parts do not need to match and both stdout and stderr are mixed together.

Sample:

2016-10-06T00:17:09.669794202Z stdout F The content of the stdout log entry 1
2016-10-06T00:17:09.669794202Z stderr F The content of the stderr log entry 1
2016-10-06T00:17:09.669794202Z stdout P First line of stdout log entry 2
2016-10-06T00:17:09.669794202Z stderr F The content of the stderr log entry 2
2016-10-06T00:17:09.669794202Z stdout F Second line of the stdout log entry 2

Resulting in: stdout:

The content of the stdout log entry 1
First line of stdout log entry 2 Second line of the stdout log entry 2

Resulting in: stderr:

The content of the stderr log entry 1
The content of the stderr log entry 2
github-actions[bot] commented 9 months ago

Test Results

     20 files  ±  0       20 suites  ±0   31m 37s :stopwatch: -10s 1 477 tests +13  1 452 :heavy_check_mark: +13    25 :zzz: ±0  0 :x: ±0  7 060 runs  +65  6 830 :heavy_check_mark: +65  230 :zzz: ±0  0 :x: ±0 

Results for commit 151e6dbf. ± Comparison against base commit 78333cf1.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (78333cf) 81.50% compared to head (151e6db) 54.70%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1223/graphs/tree.svg?width=650&height=150&src=pr&token=KrvyP8n7be&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) ```diff @@ Coverage Diff @@ ## master #1223 +/- ## =========================================== - Coverage 81.50% 54.70% -26.79% =========================================== Files 176 51 -125 Lines 42307 18428 -23879 Branches 4734 3260 -1474 =========================================== - Hits 34479 10081 -24398 - Misses 6608 7162 +554 + Partials 1220 1185 -35 ``` | [Files](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr) | Coverage Δ | | |---|---|---| | [scalyr\_agent/log\_processing.py](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr#diff-c2NhbHlyX2FnZW50L2xvZ19wcm9jZXNzaW5nLnB5) | `52.38% <29.10%> (-34.36%)` | :arrow_down: | ... and [168 files with indirect coverage changes](https://app.codecov.io/gh/scalyr/scalyr-agent-2/pull/1223/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scalyr)
alesnovak-s1 commented 8 months ago

@jmakar-s1 @tomaz-s1 Thank you for the review!